Terrain, an important limiting factor in land use change, strongly influences agricultural productivity. This study investigated the topographical characteristics of agricultural potential productivity of cropland transformations in China during the first decade of the 21st century, and explored the impacts of cropland transformations with different terrains on agricultural potential productivity as it relates to China’s national food supply. The results showed the production potential of cropland loss was much greater than that of cropland gain in most regions, and topographical characteristics of croplands losses and gains actually impacted the agricultural potential productivity in China. The losses in agricultural potential productivity was serious in regions with good terrain conditions, where the slope is lower than 5°, and the elevation is below 100 m, especially in the middle and lower Yangtze region and the Huang-Huai-Hai region. The situation for cropland loss with better quality, and expanded the worse was severe in China, and this is expected to negatively influence sustainable agricultural development in the future. This study suggests that researchers focus not only on the total area of expanded cropland but also on cropland quality, such as the different terrain conditions of the croplands, to avoid a loss in national agricultural productivity caused by the process of cropland transformation.